Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: sumdb errors constructed with malformed versions #41060

Closed
bcmills opened this issue Aug 27, 2020 · 1 comment
Closed

cmd/go: sumdb errors constructed with malformed versions #41060

bcmills opened this issue Aug 27, 2020 · 1 comment
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.16

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 27, 2020

An error message from https://build.golang.org/log/e817e5df39a7cf17e3f5825197b32eb482d453f3 demonstrates an awkward edge-case of CL 247765:

            go: golang.org/x/text@v0.3.2 (replaced by golang.org/x/text@v0.3.2/go.mod): verifying module: golang.org/x/text@v0.3.2/go.mod: reading file://$WORK/gopath1/pkg/mod/cache/download/sumdb/sum.golang.org/tile/8/1/023.p/219: no such file or directory

Somehow, the sumdb error path is generating either a module.ModuleError or a module.InvalidVersionError with the version set to v0.3.2/go.mod instead of the correct v0.3.2.

This looks like an existing bug exposed by improved logging, but since the bug is being exposed in Go 1.16, it should also be fixed in Go 1.16 (or else we can back out CL 247765 and make the failure messages worse in the typical case again).

CC @jayconrod @matloob
@bcmills bcmills added GoCommand cmd/go modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 27, 2020
@bcmills bcmills added this to the Go1.16 milestone Aug 27, 2020
@bcmills bcmills self-assigned this Aug 27, 2020
@gopherbot
Copy link

Change https://golang.org/cl/250951 mentions this issue: cmd/go/internal/modfetch: do not use mangled version strings to construct module.VersionErrors

@golang golang locked and limited conversation to collaborators Aug 27, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
2 participants
@bcmills @gopherbot