Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: bad formatting with CRLF line ending #41057

Closed
stamblerre opened this issue Aug 27, 2020 · 2 comments · Fixed by govim/govim#938
Closed

x/tools/gopls: bad formatting with CRLF line ending #41057

stamblerre opened this issue Aug 27, 2020 · 2 comments · Fixed by govim/govim#938
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.0

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Aug 27, 2020 •
edited

Seems that this issue has come back - we need a proper way to test this.

Before:

package main

/*
Gronk description
*/
func Gronk() {
    d.New()
}

After:

package main

/*
Gronk description
*/
*/
func Gronk() {
    d.New()
}
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Aug 27, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 27, 2020
@stamblerre stamblerre mentioned this issue Aug 29, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/252457 mentions this issue: internal/lsp: reproduce and fix golang/go#41057

@stamblerre stamblerre mentioned this issue Sep 2, 2020
Closed
@stamblerre
Copy link
Contributor Author

Filed an upstream issue: #41197.

myitcv added a commit to govim/govim that referenced this issue Sep 8, 2020
@myitcv
deps: update x/tools and gopls to acefd226
2157eb7 
* internal/lsp/source: move completion to its own package acefd226
* internal/lsp/source: support some fzf-like tokens in symbol matching ea3a2cdb
* internal/lsp/analysis: update fillreturns title 242af255
* internal/lsp/source: fix go1.12 build (again) 9786fa37
* internal/lsp: add support for RelatedInformation in diagnostics 39188db5
* internal/lsp: support for package completion in all files 93eecc35
* gopls/internal/regtest: use gopls hooks and add a test for staticcheck af4cc2cd
* gopls/integration/regtest: move regtests to the gopls module e2cc5a11
* present: fix newline parsing for go present 76a6aac6
* playground/socket: remove the os cleanup from start method of process 2364a5e8
* internal/lsp: reproduce and fix golang/go#41057 cf788077
* internal/lsp/cache: use the right snapshot in ModUpgrade 36b1a880
* internal/lsp: clean up some of the mod code lens code 5d67d6c6
* go/ssa: implement missing testing.testDeps SetPanicOnExit0 method 5b9ef244
@myitcv myitcv mentioned this issue Sep 8, 2020
Merged
myitcv added a commit to govim/govim that referenced this issue Sep 9, 2020
@myitcv
deps: update x/tools and gopls to acefd226 (#938)
9f55e9c 
* internal/lsp/source: move completion to its own package acefd226
* internal/lsp/source: support some fzf-like tokens in symbol matching ea3a2cdb
* internal/lsp/analysis: update fillreturns title 242af255
* internal/lsp/source: fix go1.12 build (again) 9786fa37
* internal/lsp: add support for RelatedInformation in diagnostics 39188db5
* internal/lsp: support for package completion in all files 93eecc35
* gopls/internal/regtest: use gopls hooks and add a test for staticcheck af4cc2cd
* gopls/integration/regtest: move regtests to the gopls module e2cc5a11
* present: fix newline parsing for go present 76a6aac6
* playground/socket: remove the os cleanup from start method of process 2364a5e8
* internal/lsp: reproduce and fix golang/go#41057 cf788077
* internal/lsp/cache: use the right snapshot in ModUpgrade 36b1a880
* internal/lsp: clean up some of the mod code lens code 5d67d6c6
* go/ssa: implement missing testing.testDeps SetPanicOnExit0 method 5b9ef244
@stamblerre stamblerre mentioned this issue Oct 12, 2020
Closed
@golang golang locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.0
Development

Successfully merging a pull request may close this issue.

deps: update x/tools and gopls to acefd226 govim/govim
2 participants
@stamblerre @gopherbot