Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: <h3>Frequently asked questions:</h3> is first and only header on home page #41039

Closed
jba opened this issue Aug 25, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite

Comments

@jba
Copy link
Contributor

jba commented Aug 25, 2020

The first header on a page should be marked as <h1>. It would also be preferable if FAQ was not the first header on the page. Screen reader users jump to headers to skip repeated content in the page header/nav sections and, in this case, moving to the first header navigates users past the content of the page, straight into the footer.

@jba jba added pkgsite UX Issues that involve UXD/UXR input labels Aug 25, 2020
@jba jba added this to the pkgsite/frontend milestone Aug 25, 2020
@julieqiu julieqiu added NeedsFix The path to resolution is known, but the work has not been done. and removed UX Issues that involve UXD/UXR input labels Aug 31, 2020
@jamalc
Copy link

jamalc commented Oct 1, 2020

Fixed.

@jamalc jamalc closed this as completed Oct 1, 2020
@golang golang locked and limited conversation to collaborators Oct 1, 2021
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Development

No branches or pull requests

4 participants