Skip to content

x/tools/gopls: support custom initial workspace load patterns #41019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stamblerre opened this issue Aug 25, 2020 · 3 comments
Closed

x/tools/gopls: support custom initial workspace load patterns #41019

stamblerre opened this issue Aug 25, 2020 · 3 comments
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@stamblerre
Copy link
Contributor

The ./ and ./... patterns used for the initial workspace load are specific to go list and may not be supported by other go/packages drivers. We should allow users to specify their own patterns based on their drivers via a configuration.
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Aug 25, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 25, 2020
@ianthehat
Copy link

When we talked about this during the go/packages design we decided that the meanings of some of the core go list patterns would be required for all drivers, and it was up to the driver to translate to something approximately meaningful.

@ianthehat
Copy link

Also, I think this is probably not needed for 1.0 (nobody is using a different driver yet as far as I can tell)

@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Aug 25, 2020
@stamblerre stamblerre added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Aug 25, 2020
@stamblerre
Copy link
Contributor Author

Makes sense--sounds like drivers should be supporting ./ and ./... then. Closing this.

@golang golang locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ianthehat @stamblerre @gopherbot