Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add GetReadme function #41018

Closed
julieqiu opened this issue Aug 24, 2020 · 1 comment
Closed

x/pkgsite: add GetReadme function #41018

julieqiu opened this issue Aug 24, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/design-2020

Comments

@julieqiu
Copy link
Member

As part of the new data model migration (#39629), we need to add a function to fetch a README for a give path_id.

The function signature will be:

 GetReadme(ctx context.Context, pathID int) (_ *internal.Readme, err error)

The function will execute the query below:

SELECT
   file_path,
   contents
FROM
  readmes 
WHERE
  path_id = $1
@gopherbot gopherbot added this to the Unreleased milestone Aug 24, 2020
@julieqiu julieqiu added pkgsite NeedsFix The path to resolution is known, but the work has not been done. labels Aug 24, 2020
@julieqiu julieqiu mentioned this issue Aug 24, 2020
Closed
59 tasks
@julieqiu julieqiu changed the title x/pkgsite: add GetReadMe function x/pkgsite: add GetReadme function Aug 24, 2020
@gopherbot
Copy link

Change https://golang.org/cl/250540 mentions this issue: internal/postgres: split GetDirectory into multiple functions

gopherbot pushed a commit to golang/pkgsite that referenced this issue Aug 26, 2020
@julieqiu
internal/postgres: split GetDirectory into multiple functions
130d038 
GetDirectory is split into several functions. These functions are
intended to be exported in future CLs.

For golang/go#39629
For golang/go#41017
For golang/go#41018

Change-Id: I78edfc2ab47e9947d8a8a6400460413ce0e64180
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/250540
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@golang golang locked and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/design-2020
Development

No branches or pull requests
2 participants
@julieqiu @gopherbot