Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: sync.Map keys will never be garbage collected [1.15 backport] #41011

Closed
gopherbot opened this issue Aug 24, 2020 · 5 comments
Closed

sync: sync.Map keys will never be garbage collected [1.15 backport] #41011

gopherbot opened this issue Aug 24, 2020 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.15.2

Comments

@gopherbot
Copy link

@bcmills requested issue #40999 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport to 1.15. This is a regression from Go 1.14.7, and can cause difficult-to-predict memory leaks in existing code.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 24, 2020
@gopherbot gopherbot mentioned this issue Aug 24, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.1 milestone Aug 24, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/250297 mentions this issue: [release-branch.go1.15] sync: delete dirty keys inside Map.LoadAndDelete

@jhuix

This comment has been minimized.

Sign in to view
@bcmills

This comment has been minimized.

Sign in to view
@cagedmantis
Copy link
Contributor

Approved because this is a critical problem without a workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Aug 27, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 27, 2020
@gopherbot
Copy link
Author

Closed by merging 19c8546 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Aug 27, 2020
@changkun
[release-branch.go1.15] sync: delete dirty keys inside Map.LoadAndDelete
19c8546 
Updates #40999
Fixes #41011

Change-Id: Ie32427e5cb5ed512b976b554850f50be156ce9f2
Reviewed-on: https://go-review.googlesource.com/c/go/+/250197
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit 94953d3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/250297
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@dmitshur dmitshur modified the milestones: Go1.15.1, Go1.15.2 Sep 1, 2020
@golang golang locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.15.2
Development

No branches or pull requests
5 participants
@cagedmantis @dmitshur @bcmills @gopherbot @jhuix