Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: UpsertSearchDocuments should not store synopsis for non-redistributable packages #40971

Closed
jba opened this issue Aug 21, 2020 · 1 comment
Closed

x/pkgsite: UpsertSearchDocuments should not store synopsis for non-redistributable packages #40971

jba opened this issue Aug 21, 2020 · 1 comment
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Milestone
pkgsite/search

Comments

@jba
Copy link
Contributor

jba commented Aug 21, 2020

If a package is not redistributable, we can't store its doc synopsis. That decision should happen at the DataSource (that is, DB) level, in UpsertSearchDocuments.

It's not quite a trivial change because we also have to consider the flag for bypassing license checks, which UpsertSearchDocuments currently can't see because it's on the postgres.DB struct.
@jba jba added the pkgsite label Aug 21, 2020
@jba jba added this to the pkgsite/search milestone Aug 21, 2020
@jba jba self-assigned this Aug 21, 2020
@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 22, 2020
@jba jba removed the Documentation label Aug 24, 2020
@gopherbot
Copy link

Change https://golang.org/cl/250637 mentions this issue: internal/postgres: enforce redistributability and allow bypass for search

@golang golang locked and limited conversation to collaborators Aug 26, 2021
@hyangah hyangah added the pkgsite/search Issues related to pkg.go.dev search functionality label May 20, 2022
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Projects
None yet
Milestone
pkgsite/search
Development

No branches or pull requests
4 participants
@hyangah @julieqiu @gopherbot @jba