Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: subdirectories tab for k8s.io/kubernetes overflows table #40946

Closed
julieqiu opened this issue Aug 21, 2020 · 4 comments
Closed

x/pkgsite: subdirectories tab for k8s.io/kubernetes overflows table #40946

julieqiu opened this issue Aug 21, 2020 · 4 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unreleased

Comments

@julieqiu
Copy link
Member

The content on https://pkg.go.dev//k8s.io/kubernetes overflows the table:

image

Setting max-width: 30rem on .Directories td seems to fix this page:

image

/cc @jamalc
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2020
@julieqiu julieqiu added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Aug 21, 2020
@nickel8448
Copy link

Can I take this issue?

@julieqiu
Copy link
Member Author

Go ahead, thanks @rahulw!

@julieqiu julieqiu added help wanted Suggested Issues that may be good for new contributors looking for work to do. labels Aug 21, 2020
@nickel8448
Copy link

Created a pull request on the pkgsite repo - golang/pkgsite#4

nickel8448 pushed a commit to nickel8448/pkgsite that referenced this issue Aug 21, 2020
x/pkgsite: Fix the width of Subdirectories table
88f996e 
The subdirectories table is overflowing for package
k8s.io/kubernetes hence adding a maximum width
to the table.

Fixes golang/go#40946
nickel8448 pushed a commit to nickel8448/pkgsite that referenced this issue Aug 21, 2020
x/pkgsite: Fix the width of Subdirectories table
ea918f1 
The subdirectories table is overflowing for package
https://pkg.go.dev//k8s.io/kubernetes hence adding a maximum
width to the table.

Fixes golang/go#40946
@nickel8448 nickel8448 mentioned this issue Aug 21, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/249839 mentions this issue: x/pkgsite: Fix the width of Subdirectories table

@golang golang locked and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

x/pkgsite: Fix the width of Subdirectories table nickel8448/pkgsite
3 participants
@nickel8448 @julieqiu @gopherbot