Skip to content

x/pkgsite: trim https:// from source links #40943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julieqiu opened this issue Aug 21, 2020 · 12 comments
Closed

x/pkgsite: trim https:// from source links #40943

julieqiu opened this issue Aug 21, 2020 · 12 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Member

Source code links on the overview tab currently show "https://". We should be trim the https:// when displaying the link:

Example - for https://pkg.go.dev/golang.org/x/pkgsite@v0.0.0-20200820201329-47151e4cbeb8/cmd/frontend?tab=overview, we currently show:

image

Instead, we should show:

image
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2020
@julieqiu julieqiu added pkgsite help wanted NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do. labels Aug 21, 2020
@tooolbox
Copy link

@julieqiu I was wandering past and noticed that you have a few issues with help wanted on them. Is this literally something that a community member could hit, or are you more using the labels for internal-in-the-open use?

Either one is great, just pure curiosity.

@tooolbox
Copy link

Sorry, I just saw this: https://github.com/golang/pkgsite/blob/master/CONTRIBUTING.md#finding-issues

In particular, we would love your help on issues tagged with the help wanted label.

👍

@wingyplus
Copy link
Contributor

I think we need to add template function for strip http scheme. What do you think?

@nickel8448
Copy link

Hey @wingyplus and @julieqiu if it is ok, can I take this issue?

@tooolbox
Copy link

tooolbox commented Aug 22, 2020 •
edited
Loading

Before you begin working on an issue, please leave a comment that you are claiming it.

I think you can just claim it and do it, I don't think you need to get an acceptance, although I could be wrong.

EDIT: Sorry, might be good to coordinate with @wingyplus since he has talked about it already, I more meant that if the issue is created and says help wanted we probably don't need to check with @julieqiu each time because otherwise she'll turn into a full-time dev manager 😉

@nickel8448
Copy link

Before you begin working on an issue, please leave a comment that you are claiming it.

I think you can just claim it and do it, I don't think you need to get an acceptance, although I could be wrong.

EDIT: Sorry, might be good to coordinate with @wingyplus since he has talked about it already, I more meant that if the issue is created and says help wanted we probably don't need to check with @julieqiu each time because otherwise she'll turn into a full-time dev manager 😉

Hey @tooolbox, thanks for your comment. What you are saying makes complete sense.

I will coordinate with @wingyplus to check who can contribute to this. I am fairly new to this hence learning the ropes.

@wingyplus please let me know if you are already working on this or not.

@wingyplus
Copy link
Contributor

@rahulw i didn't start working on this. So you can take this one.

nickel8448 pushed a commit to nickel8448/pkgsite that referenced this issue Aug 23, 2020
x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links

Verified

This commit was signed with the committer’s verified signature.
mcculls Stuart McCulloch
GPG key ID: 29641ACA805A0ABB
Verified
Learn about vigilant mode
8dc2020 
Trimming the URL by adding a new function to overview.go which trims the
URL

Fixes golang/go#40943
@nickel8448 nickel8448 mentioned this issue Aug 23, 2020
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/250040 mentions this issue: x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links

nickel8448 pushed a commit to nickel8448/pkgsite that referenced this issue Aug 27, 2020
x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links

Verified

This commit was signed with the committer’s verified signature.
mcculls Stuart McCulloch
GPG key ID: 29641ACA805A0ABB
Verified
Learn about vigilant mode
d642347 
Trimming the URL by creating a new template function which trims the
scheme of the URL

Fixes golang/go#40943
nickel8448 pushed a commit to nickel8448/pkgsite that referenced this issue Aug 27, 2020
x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links

Verified

This commit was signed with the committer’s verified signature.
mcculls Stuart McCulloch
GPG key ID: 29641ACA805A0ABB
Verified
Learn about vigilant mode
32ada83 
Trimming the URL by creating a new template function which trims the
scheme of the URL

Fixes golang/go#40943
nickel8448 pushed a commit to nickel8448/pkgsite that referenced this issue Aug 28, 2020
x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links
6177bf8 
Trimming the URL by creating a new template function which trims the
scheme of the URL

Fixes golang/go#40943
@nickel8448 nickel8448 mentioned this issue Aug 28, 2020
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/251277 mentions this issue: x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links

nickel8448 pushed a commit to nickel8448/pkgsite that referenced this issue Sep 2, 2020
x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links
7310642 
Trimming the URL by creating a new template function which trims the
scheme of the URL

Fixes golang/go#40943
@julieqiu julieqiu removed the website label Sep 19, 2020
@julieqiu julieqiu removed the website label Sep 19, 2020
nickel8448 pushed a commit to nickel8448/pkgsite that referenced this issue Oct 31, 2020
x/pkgsite: trim HTTP or HTTPS Scheme from source code links
85c8144 
A new template function is created, which trims the scheme of the URL.
Tests in server_test.go are modified accordingly.

Fixes golang/go#40943
@nickel8448 nickel8448 mentioned this issue Oct 31, 2020
Closed
@nickel8448
Copy link

Apologies for abandoning this.
I have created a new pull request - golang/pkgsite#13
I have incorporated all the feedback which was given to me in the previous pull request.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/266998 mentions this issue: x/pkgsite: trim HTTP or HTTPS Scheme from source code links

@Stexxe Stexxe mentioned this issue Apr 14, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/310229 mentions this issue: x/pkgsite: remove protocol from source code links

@golang golang locked and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
pkgsite/unplanned
5 participants
@wingyplus @nickel8448 @tooolbox @julieqiu @gopherbot