Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add tests to TestCreatePackageHeader where isLatest = true #40941

Closed
julieqiu opened this issue Aug 21, 2020 · 6 comments
Closed

x/pkgsite: add tests to TestCreatePackageHeader where isLatest = true #40941

julieqiu opened this issue Aug 21, 2020 · 6 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unreleased

Comments

@julieqiu
Copy link
Member

TestCreatePackage only tests for cases where isLatest = false:

https://github.com/golang/pkgsite/blob/master/internal/frontend/header_test.go#L140

We should add test cases for isLatest = true.
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2020
@julieqiu julieqiu changed the title x/pkgsite: add tests to TestCreatePackageHeader where isLatest = true x/pkgsite: add tests to TestCreatePackageHeader where isLatest = true Aug 21, 2020
@julieqiu julieqiu added pkgsite NeedsFix The path to resolution is known, but the work has not been done. help wanted Suggested Issues that may be good for new contributors looking for work to do. labels Aug 21, 2020
@nickel8448
Copy link

Please let me know if I can add this test case

@julieqiu
Copy link
Member Author

Please do, @rahulw!

@nickel8448
Copy link

Thanks. I will start work on this very soon.

@gopherbot
Copy link

Change https://golang.org/cl/249957 mentions this issue: x/pkgsite: fix UT TestCreatePackage

@ShaileshSurya
Copy link

Hi @rahulw, I am really sorry that I had not claimed this bug and started working on it. I was also unaware that you have already claimed this bug. Sorry for the confusion. If you don't mind can I take this further?

@nickel8448
Copy link

Hey @ShaileshSurya, please feel free to submit the code. Thanks

@golang golang locked and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@nickel8448 @julieqiu @gopherbot @ShaileshSurya