Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: don't tee /_ah/* requests from godoc.org #40915

Closed
julieqiu opened this issue Aug 19, 2020 · 1 comment
Closed

x/pkgsite: don't tee /_ah/* requests from godoc.org #40915

julieqiu opened this issue Aug 19, 2020 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
Unreleased

Comments

@julieqiu
Copy link
Member

julieqiu commented Aug 19, 2020 •
edited

As described in #39702, the teeproxy was implemented as a way to forward requests from godoc.org to pkg.go.dev and ensure that pkg.go.dev can handle the current workload of godoc.org.

We shouldn't tee any requests from AppEngine, such as /_ah/ready.

A filter was previously implemented here:
https://github.com/golang/gddo/blob/051695c33a3fcf220bffc5815eebc4b0a346c983/gddo-server/main.go#L1042

However, we are still seeing these requests via the teeproxy.

/cc @shaqque
@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2020
@julieqiu julieqiu added pkgsite NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 19, 2020
@gopherbot
Copy link

Change https://golang.org/cl/249438 mentions this issue: internal/teeproxy: don't tee App Engine requests

@golang golang locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@julieqiu @gopherbot