Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: "Frequently asked questions" hyperlinks have insufficient color contrast #40907

Closed
julieqiu opened this issue Aug 19, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone

Comments

@julieqiu
Copy link
Member

julieqiu commented Aug 19, 2020

The hyperlinks in <h3> of the site footer lack sufficient color contrast against the background of the <div class="Questions-content">. The hyperlink color should be made darker or the background of the div class should be made lighter.

/cc @jamalc

@julieqiu julieqiu added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Aug 19, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2020
@Piyushhbhutoria
Copy link

I would like to work on it. Need some more insight for this issue

@jamalc
Copy link

jamalc commented Aug 20, 2020

Hi @Piyushhbhutoria thank you for your interest. This color contrast on the FAQ links was already fixed in a previous commit. I'll close the issue.

@jamalc jamalc closed this as completed Aug 20, 2020
@golang golang locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Development

No branches or pull requests

4 participants