Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: linux 386+amd64 longtest builders not completing #40861

Closed
dmitshur opened this issue Aug 18, 2020 · 1 comment
Closed

cmd/go: linux 386+amd64 longtest builders not completing #40861

dmitshur opened this issue Aug 18, 2020 · 1 comment
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone

Comments

@dmitshur
Copy link
Contributor

From https://build.golang.org:

image

It appears that starting with commit f30044a (CL 248326), linux longtest builders are not making progress past cmd/fix tests:

##### Testing packages.
ok  	archive/tar	0.021s
ok  	archive/zip	23.818s
[...]
ok  	cmd/compile/internal/syntax	1.831s
ok  	cmd/compile/internal/test	0.004s [no tests to run]
ok  	cmd/compile/internal/types	0.003s
ok  	cmd/cover	0.749s
ok  	cmd/doc	0.119s
ok  	cmd/fix	0.423s
<stuck and no more progress past this point>

From looking at successful logs, the next package to be tested is cmd/go. The aforementioned CL touches something about parallelism in cmd/go, which might be affecting some tests that are not run with -short flag.

Note that the windows longtest builder is succeeding. Maybe the same test doesn't run there, or maybe it's something else.

I'll look into a creating a revert CL and see if linux longtest builders pass with it.

/cc @matloob

@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. GoCommand cmd/go Soon This needs to be done soon. (regressions, serious bugs, outages) labels Aug 18, 2020
@dmitshur dmitshur added this to the Go1.16 milestone Aug 18, 2020
@dmitshur dmitshur pinned this issue Aug 18, 2020
@dmitshur dmitshur self-assigned this Aug 18, 2020
@gopherbot
Copy link

Change https://golang.org/cl/249017 mentions this issue: cmd/go: revert 3 CLs affecting par.Work, context propagation, tracing

@dmitshur dmitshur unpinned this issue Aug 18, 2020
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 19, 2020
@golang golang locked and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Development

No branches or pull requests

2 participants