Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: bug due to typo in (*.internal/types.Type).cmp for TSSA #40837

Closed
Celision opened this issue Aug 17, 2020 · 4 comments
Closed

cmd/compile: bug due to typo in (*.internal/types.Type).cmp for TSSA #40837

Celision opened this issue Aug 17, 2020 · 4 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Go1.16

Comments

@Celision
Copy link

go/src/cmd/compile/internal/types/type.go

Line 1029 in 51ac0f0

xname := t.Extra.(string) 

xname := t.Extra.(string)

should ACTUALLY BE:

xname := x.Extra.(string)
@odeke-em
Copy link
Member

Thank you @Praxisproject for this report and welcome to the Go project! Great catch with a code audit, we’ve had that in for 3 years. If you’ve got time could you please send a patch and you’ll become a Go contributor too.

/cc @josharian @randall77

@odeke-em odeke-em added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 17, 2020
@odeke-em odeke-em changed the title Go/src/cmd/compile/internal/types/type.go line 1029 typo/error! cmd/compile: bug due to typo in (*.internal/types.Type).cmp for TSSA Aug 17, 2020
@josharian josharian added help wanted Suggested Issues that may be good for new contributors looking for work to do. labels Aug 18, 2020
@josharian josharian added this to the Go1.16 milestone Aug 18, 2020
BrandonKoerner pushed a commit to Celision/go that referenced this issue Aug 18, 2020
fix issue golang#40837
13aa0e8
@Celision Celision mentioned this issue Aug 18, 2020
Closed
@Celision
Copy link
Author

Heyo. Submitted PR.

@gopherbot
Copy link

Change https://golang.org/cl/248780 mentions this issue: cmd/compile: resolve typo in (*.internal/types.Type).cmp

@gopherbot
Copy link

Change https://golang.org/cl/248781 mentions this issue: cmd/compile: fix SSA type comparison

@golang golang locked and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Go1.16
Development

Successfully merging a pull request may close this issue.

cmd/compile: resolve typo in (*.internal/types.Type).cmp Celision/go
4 participants
@josharian @odeke-em @gopherbot @Celision