Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add regression tests for file watching #40818

Open
4 tasks
stamblerre opened this issue Aug 16, 2020 · 0 comments
Open
4 tasks

x/tools/gopls: add regression tests for file watching #40818

stamblerre opened this issue Aug 16, 2020 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Aug 16, 2020

Some cases that lack coverage:

  • Moving a declaration to a new file
  • Adding a new declaration to the same file
  • Adding a new declaration a different file
  • Check that closing a buffer clears errors
    • Real-life example: You switch branches with 1 open file in your editor and see errors because that file is now an overlay. You close the file and its errors clear.
@stamblerre stamblerre added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 16, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Aug 16, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 16, 2020
@stamblerre stamblerre changed the title x/tools/gopls: add more file change regression tests x/tools/gopls: tracking issue for additional regression tests Sep 9, 2020
@stamblerre stamblerre changed the title x/tools/gopls: tracking issue for additional regression tests x/tools/gopls: add regression tests for file watching Sep 9, 2020
@stamblerre stamblerre added this to Non-critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Non-critical to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Critical to Testing in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre removed this from Testing in vscode-go: gopls by default Jan 14, 2021
@stamblerre stamblerre modified the milestones: gopls/v0.6.3, gopls/v1.0.0 Jan 14, 2021
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
Development

No branches or pull requests

2 participants