Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/test2json: tests that panic are marked as passing [1.15 backport] #40805

Closed
gopherbot opened this issue Aug 14, 2020 · 3 comments
Closed

cmd/test2json: tests that panic are marked as passing [1.15 backport] #40805

gopherbot opened this issue Aug 14, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.15.2

Comments

@gopherbot
Copy link

@bcmills requested issue #40132 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport to Go 1.15. This seems like a significant regression.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 14, 2020
@gopherbot gopherbot mentioned this issue Aug 14, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.1 milestone Aug 14, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/248725 mentions this issue: [release-branch.go1.15] cmd/test2json: do not emit a final Action if the result is not known

@dmitshur dmitshur modified the milestones: Go1.15.1, Go1.15.2 Sep 1, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Sep 2, 2020

We've considered this in a release meeting. Approving as it is a serious issue without a workaround. Only 1.15 needs this backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Sep 2, 2020
@gopherbot
Copy link
Author

Closed by merging 09b2897 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Sep 2, 2020
@dmitshur
[release-branch.go1.15] cmd/test2json: do not emit a final Action if …
09b2897 
…the result is not known

If we are parsing a test output, and the test does not end in the
usual PASS or FAIL line (say, because it panicked), then we need the
exit status of the test binary in order to determine whether the test
passed or failed. If we don't have that status available, we shouldn't
guess arbitrarily — instead, we should omit the final "pass" or "fail"
action entirely.

(In practice, we nearly always DO have the final status, such as when
running 'go test' or 'go tool test2json some.exe'.)

Updates #40132
Fixes #40805

Change-Id: Iae482577361a6033395fe4a05d746b980e18c3de
Reviewed-on: https://go-review.googlesource.com/c/go/+/248624
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 1b86bdb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/248725
claucece pushed a commit to claucece/go that referenced this issue Oct 22, 2020
@claucece
[release-branch.go1.15] cmd/test2json: do not emit a final Action if …
9f82b18 
…the result is not known

If we are parsing a test output, and the test does not end in the
usual PASS or FAIL line (say, because it panicked), then we need the
exit status of the test binary in order to determine whether the test
passed or failed. If we don't have that status available, we shouldn't
guess arbitrarily — instead, we should omit the final "pass" or "fail"
action entirely.

(In practice, we nearly always DO have the final status, such as when
running 'go test' or 'go tool test2json some.exe'.)

Updates golang#40132
Fixes golang#40805

Change-Id: Iae482577361a6033395fe4a05d746b980e18c3de
Reviewed-on: https://go-review.googlesource.com/c/go/+/248624
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 1b86bdb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/248725
@golang golang locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.15.2
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot