Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/mail: change in behavior of ParseAddressList("") in 1.15 [1.15 backport] #40804

Closed
gopherbot opened this issue Aug 14, 2020 · 3 comments
Closed

net/mail: change in behavior of ParseAddressList("") in 1.15 [1.15 backport] #40804

gopherbot opened this issue Aug 14, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.15.2

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #40803 to be considered for backport to the next 1.15 minor release.

@gopherbot Please open backport to 1.15.

This is a minor but unintended change in behavior in 1.15. We should restore the behavior seen in all earlier Go releases.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 14, 2020
@gopherbot gopherbot mentioned this issue Aug 14, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.1 milestone Aug 14, 2020
@dmitshur
Copy link
Contributor

Approved per discussion in a release meeting. This is fixing an unintentional regression. Only 1.15 needs this backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 22, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/251167 mentions this issue: [release-branch.go1.15] net/mail: return error on empty address list

@gopherbot
Copy link
Author

Closed by merging 1fa328f to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Aug 28, 2020
@ianlancetaylor
[release-branch.go1.15] net/mail: return error on empty address list
1fa328f 
This restores the handling accidentally changed in CL 217377.

Fixes #40804
For #40803
For #36959

Change-Id: If77fbc0c2a1dde4799f760affdfb8dde9bcaf458
Reviewed-on: https://go-review.googlesource.com/c/go/+/248598
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Jeremy Fishman <jfishman@cloudflare.com>
(cherry picked from commit 3e636ab)
Reviewed-on: https://go-review.googlesource.com/c/go/+/251167
@dmitshur dmitshur modified the milestones: Go1.15.1, Go1.15.2 Sep 1, 2020
@golang golang locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.15.2
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot