Skip to content

cmd/go: in 1.15: change in "go test" argument parsing [1.15 backport] #40802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 14, 2020 · 3 comments
Closed

cmd/go: in 1.15: change in "go test" argument parsing [1.15 backport] #40802

gopherbot opened this issue Aug 14, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.15.2

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #40763 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport to 1.15
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 14, 2020
@gopherbot gopherbot mentioned this issue Aug 14, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.1 milestone Aug 14, 2020
@bcmills bcmills changed the title cmd/go: in 1.15: change in of "go test" argument parsing [1.15 backport] cmd/go: in 1.15: change in "go test" argument parsing [1.15 backport] Aug 14, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/248726 mentions this issue: [release-branch.go1.15] cmd/go/internal/test: keep looking for go command flags after ambiguous test flag

@dmitshur dmitshur modified the milestones: Go1.15.1, Go1.15.2 Sep 1, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Sep 2, 2020

We've considered this in a release meeting. Approving as it is a serious issue without a workaround. Only 1.15 needs this backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Sep 2, 2020
@gopherbot
Copy link
Contributor Author

Closed by merging 76a89d6 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Sep 2, 2020
@dmitshur
[release-branch.go1.15] cmd/go/internal/test: keep looking for go com…
76a89d6 
…mand flags after ambiguous test flag

Updates #40763
Fixes #40802

Change-Id: I275970d1f8561414571a5b93e368d68fa052c60f
Reviewed-on: https://go-review.googlesource.com/c/go/+/248618
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 797124f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/248726
claucece pushed a commit to claucece/go that referenced this issue Oct 22, 2020
@claucece
[release-branch.go1.15] cmd/go/internal/test: keep looking for go com…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
claucece Sofía Celi
GPG key ID: 311C4B2B2FB51BE8
Expired
Verified
Learn about vigilant mode
4b9c5e8 
…mand flags after ambiguous test flag

Updates golang#40763
Fixes golang#40802

Change-Id: I275970d1f8561414571a5b93e368d68fa052c60f
Reviewed-on: https://go-review.googlesource.com/c/go/+/248618
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 797124f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/248726
@golang golang locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.15.2
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot