Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: inline marker targets not reachable after assembly on ppc64x [1.15 backport] #40767

Closed
gopherbot opened this issue Aug 13, 2020 · 3 comments
Closed

cmd/compile: inline marker targets not reachable after assembly on ppc64x [1.15 backport] #40767

gopherbot opened this issue Aug 13, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.15.2

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #40689 to be considered for backport to the next 1.15 minor release.

@gopherbot Please backport to 1.14 and 1.15

This bug can cause tracebacks to hang. There is no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 13, 2020
@gopherbot gopherbot mentioned this issue Aug 13, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.1 milestone Aug 13, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/248381 mentions this issue: cmd/internal/obj/ppc64: don't remove NOP in assembler

@dmitshur dmitshur modified the milestones: Go1.15.1, Go1.15.2 Sep 1, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Sep 2, 2020

Approving per discussion in a release meeting. This backport applies to both 1.15 (this issue) and 1.14 (#40766).

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Sep 2, 2020
@dmitshur dmitshur mentioned this issue Sep 2, 2020
Closed
@gopherbot
Copy link
Author

Closed by merging a5fb3b1 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Sep 3, 2020
@laboger @dmitshur
[release-branch.go1.15] cmd/internal/obj/ppc64: don't remove NOP in a…
a5fb3b1 
…ssembler

Previously, the assembler removed NOPs from the Prog list in
obj9.go. NOPs shouldn't be removed if they were added as
an inline mark, as described in the issue below.

Fixes #40767

Once the NOPs were left in the Prog list, some instructions
were flagged as invalid because they had an operand which was
not represented in optab. In order to preserve the previous
assembler behavior, entries were added to optab for those
operand cases. They were not flagged as errors before because
the NOP instructions were removed before the code to check the
valid opcode/operand combinations.

Change-Id: Iae5145f94459027cf458e914d7c5d6089807ccf8
Reviewed-on: https://go-review.googlesource.com/c/go/+/247842
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Paul Murphy <murp@ibm.com>
Reviewed-by: Michael Munday <mike.munday@ibm.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 7d7bd5a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/248381
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
claucece pushed a commit to claucece/go that referenced this issue Oct 22, 2020
@laboger @claucece
[release-branch.go1.15] cmd/internal/obj/ppc64: don't remove NOP in a…
c83001d 
…ssembler

Previously, the assembler removed NOPs from the Prog list in
obj9.go. NOPs shouldn't be removed if they were added as
an inline mark, as described in the issue below.

Fixes golang#40767

Once the NOPs were left in the Prog list, some instructions
were flagged as invalid because they had an operand which was
not represented in optab. In order to preserve the previous
assembler behavior, entries were added to optab for those
operand cases. They were not flagged as errors before because
the NOP instructions were removed before the code to check the
valid opcode/operand combinations.

Change-Id: Iae5145f94459027cf458e914d7c5d6089807ccf8
Reviewed-on: https://go-review.googlesource.com/c/go/+/247842
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Paul Murphy <murp@ibm.com>
Reviewed-by: Michael Munday <mike.munday@ibm.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 7d7bd5a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/248381
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.15.2
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot