Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: performance regression about 2~3ms since Go 1.15 on macOS, due to linking two more shared libraries [1.15 backport] #40764

Closed
gopherbot opened this issue Aug 13, 2020 · 6 comments
Closed

runtime: performance regression about 2~3ms since Go 1.15 on macOS, due to linking two more shared libraries [1.15 backport] #40764

gopherbot opened this issue Aug 13, 2020 · 6 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.15.2

Comments

@gopherbot
Copy link

@FiloSottile requested issue #40727 to be considered for backport to the next 1.15 minor release.

@gopherbot please open a backport issue for Go 1.15.

I am not sure this qualifies to be backported, but it might as it's a regression with no workaround.

The team will evaluate it in the backport issue.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 13, 2020
@gopherbot gopherbot mentioned this issue Aug 13, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.1 milestone Aug 13, 2020
@randall77
Copy link
Contributor

I vote against backporting this. It's 3ms extra time on process startup, which doesn't seem serious enough to warrant a backport.

@itchyny
Copy link
Contributor

itchyny commented Aug 14, 2020

The 3ms extra time seems to be based the original issue, so if you judge whether or not backport based on the overhead amount, would you benchmark and reevaluate the overhead please?

@networkimprov
Copy link

Possibly related: #40781

@networkimprov
Copy link

Backport posted:

Change https://golang.org/cl/248719 mentions this issue: [release-branch.go1.15] cmd/link: link dynamic library automatically

cc @cherrymui

@cherrymui
Copy link
Member

I made a CL anyway, but feel free to reject (or accept).

@dmitshur
Copy link
Contributor

We have discussed this backport request in a release meeting, and decided this issue does not meet the bar for being backported to Go 1.15. The fix for this issue will be available in Go 1.16.

@dmitshur dmitshur modified the milestones: Go1.15.1, Go1.15.2 Sep 1, 2020
@golang golang locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.15.2
Development

No branches or pull requests
6 participants
@itchyny @networkimprov @dmitshur @randall77 @gopherbot @cherrymui