Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unicode: support version 13 #40755

Closed
ainar-g opened this issue Aug 13, 2020 · 4 comments
Closed

unicode: support version 13 #40755

ainar-g opened this issue Aug 13, 2020 · 4 comments
Labels
FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.16

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Aug 13, 2020

What version of Go are you using (go version)?

$ go version
go version go1.15 linux/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/ainar/.cache/go-build"
GOENV="/home/ainar/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/ainar/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/ainar/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/ainar/go/go1.15"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/ainar/go/go1.15/pkg/tool/linux_amd64"
GCCGO="/usr/bin/gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build309808131=/tmp/go-build -gno-record-gcc-switches"

What did you do?

package main

import "unicode"

func main() {
	println(unicode.Version)
}

What did you expect to see?

13.0.0

What did you see instead?

12.0.0

I didn't find a recurring issue for Unicode updates, so I decided to submit this one. Please feel free to close if there is one already.
@dmitshur dmitshur added FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 13, 2020
@dmitshur dmitshur added this to the Backlog milestone Aug 13, 2020
@dmitshur
Copy link
Contributor

/cc @robpike @mpvl per owners.

@ainar-g
Copy link
Contributor Author

ainar-g commented Aug 15, 2020

If the process of regenerating the code is documented somewhere, I am ready to try and send a CL myself.

@gopherbot
Copy link

Change https://golang.org/cl/248765 mentions this issue: unicode: upgrade to Unicode 13.0.0

@martisch
Copy link
Contributor

I second the question: where is the procedure documented to generate the CL?

My motivation to knowing is not concerned with generating the update CL but more how to change the process to potentially generate more binary size efficient datastructures for the unicode package.

@dmitshur dmitshur modified the milestones: Backlog, Go1.16 Aug 18, 2020
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 18, 2020
@dmitshur dmitshur mentioned this issue Dec 28, 2020
Closed
@golang golang locked and limited conversation to collaborators Aug 20, 2021
rcrozean pushed a commit to rcrozean/go that referenced this issue Oct 24, 2022
@mpvl @rcrozean
unicode: upgrade to Unicode 13.0.0
248280d 
Fixes golang#40755

Change-Id: I14b3977317994095db8ae1bd873c174641209356
Reviewed-on: https://go-review.googlesource.com/c/go/+/248765
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
rcrozean pushed a commit to rcrozean/go that referenced this issue Oct 25, 2022
@mpvl @rcrozean
unicode: upgrade to Unicode 13.0.0
f4da22b 
Fixes golang#40755

Change-Id: I14b3977317994095db8ae1bd873c174641209356
Reviewed-on: https://go-review.googlesource.com/c/go/+/248765
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
4 participants
@martisch @dmitshur @ainar-g @gopherbot