Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

top-level: Go binary checked in to git repository? #40740

Closed
kevinburke1 opened this issue Aug 12, 2020 · 8 comments
Closed

top-level: Go binary checked in to git repository? #40740

kevinburke1 opened this issue Aug 12, 2020 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.16

Comments

@kevinburke1
Copy link

It looks like commit cfbd1c7 added a go binary at the root of the Git repository.

0s kevin in ~/src/github.com/golang/go
± (master) $ ls -al
total 14M
drwxr-xr-x  22 kevin staff  704 Aug 12 13:20 .
drwxr-xr-x   9 kevin staff  288 Feb 19 16:20 ..
drwxr-xr-x  13 kevin staff  416 Aug 12 13:23 .git
-rw-r--r--   1 kevin staff  639 Jun  8 09:13 .gitattributes
drwxr-xr-x   6 kevin staff  192 Jan  6  2020 .github
-rw-r--r--   1 kevin staff  928 Aug  5  2019 .gitignore
-rw-r--r--   1 kevin staff  55K Jul  8 11:07 AUTHORS
-rw-r--r--   1 kevin staff 1.4K Aug  5  2019 CONTRIBUTING.md
-rw-r--r--   1 kevin staff  94K Aug 11 10:55 CONTRIBUTORS
-rw-r--r--   1 kevin staff 1.5K Aug  5  2019 LICENSE
-rw-r--r--   1 kevin staff 1.3K Aug  5  2019 PATENTS
-rw-r--r--   1 kevin staff 1.6K Aug  5  2019 README.md
-rw-r--r--   1 kevin staff  397 Sep 26  2019 SECURITY.md
drwxr-xr-x  21 kevin staff  672 Jul 16 20:30 api
drwxr-xr-x  46 kevin staff 1.5K Aug 12 10:37 doc
-rw-r--r--   1 kevin staff 5.6K Aug  5  2019 favicon.ico
-rwxr-xr-x   1 kevin staff  14M Aug 12 13:20 go
drwxr-xr-x   3 kevin staff   96 Aug  5  2019 lib
drwxr-xr-x  14 kevin staff  448 Oct 23  2019 misc
-rw-r--r--   1 kevin staff   26 Aug  5  2019 robots.txt
drwxr-xr-x  70 kevin staff 2.2K Jul 25 22:36 src
drwxr-xr-x 328 kevin staff  11K Jul 30 13:59 test

It's executable on Darwin, here is what prints out.

$ ./go version
go version devel +0ea11145ff Tue Jun 30 15:04:06 2020 -0400 darwin/amd64
@ianlancetaylor
Copy link
Contributor

CC @matloob @andybons @dmitshur

@ianlancetaylor ianlancetaylor mentioned this issue Aug 12, 2020
Open
@matloob
Copy link
Contributor

matloob commented Aug 12, 2020

Thanks for catching this.

@andybons
Copy link
Member

Let’s rewrite history to remove it.

@andybons
Copy link
Member

I’ll take this as I’m on call.

@andybons andybons self-assigned this Aug 12, 2020
@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Aug 12, 2020
@andybons andybons added this to the Go1.16 milestone Aug 12, 2020
@andybons
Copy link
Member

Reverting to 2bfa45cfa994512c47da2d98f3baca5bb474ec9b (the commit right before)

@andybons
Copy link
Member

This is now done.

@andybons
Copy link
Member

andybons commented Aug 12, 2020 •
edited

@matloob you’ll have to reland the changes that were dropped.
@cherrymui you’ll have to redo the dev.link merge.

@cherrymui
Copy link
Member

Done. Thanks.

@golang golang locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
6 participants
@andybons @ianlancetaylor @gopherbot @cherrymui @matloob @kevinburke1