Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: correctly observe the -remote flags for commands other than serve #40732

Closed
findleyr opened this issue Aug 12, 2020 · 1 comment
Closed

x/tools/gopls: correctly observe the -remote flags for commands other than serve #40732

findleyr opened this issue Aug 12, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.0

Comments

@findleyr
Copy link
Contributor

Currently, the handling for -remote is happening within the LSP forwarder itself, meaning it only works for the gopls serve command.

This was an oversight. This functionality should work identically for all commands.
@findleyr findleyr self-assigned this Aug 12, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 12, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 12, 2020
@gopherbot
Copy link

Change https://golang.org/cl/248181 mentions this issue: internal/lsp/cmd: make -remote consistent across commands

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v.0.5.0 Aug 15, 2020
@golang golang locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.0
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr