Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal: duplicate initialization of buildcontext #40707

Closed
liu-xuewen opened this issue Aug 12, 2020 · 3 comments
Closed

cmd/go/internal: duplicate initialization of buildcontext #40707

liu-xuewen opened this issue Aug 12, 2020 · 3 comments
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Backlog

Comments

@liu-xuewen
Copy link
Contributor

liu-xuewen commented Aug 12, 2020 •
edited

What version of Go are you using (go version)?

$ go version
1.4.2

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
Linux amd64

What did you do?

nothing

What did you expect to see?

Remove the build.Context Repeated initialization
https://github.com/golang/go/pull/40581/files

What did you see instead?

During variable initialization, the build.Context Repeated initialization
@dmitshur
Copy link
Contributor

Thanks for reporting an issue. There's not enough information here to understand what the problem is.

You mention "Repeated initialization". What is repeated? In the PR you've linked, it looks like initialization of GOPATH, GOOS, GOARCH, and CgoEnabled fields from environment variables is being removed, but I don't see where else it's being done. Can you please elaborate?

/cc @jayconrod per owners.

@dmitshur dmitshur added GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Aug 17, 2020
@dmitshur dmitshur added this to the Backlog milestone Aug 17, 2020
@jayconrod
Copy link
Contributor

@liu-xuewen Please explain exactly what the problem is. We're not sure what you're trying to fix. There is no duplicate initialization being removed in CL 246797. That change appears to break cross-compilation when GOOS and GOARCH have been written with go env -w.

@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@jayconrod @dmitshur @gopherbot @liu-xuewen