Skip to content

plugin: program on linux/s390x sometimes hangs after calling "plugin.Open" [1.14 backport] #40694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 11, 2020 · 3 comments
Closed

plugin: program on linux/s390x sometimes hangs after calling "plugin.Open" [1.14 backport] #40694

gopherbot opened this issue Aug 11, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.10

Comments

@gopherbot
Copy link
Contributor

@mundaym requested issue #40473 to be considered for backport to the next 1.14 minor release.

@gopherbot please open backport issues.

This is a bug that causes programs to intermittently crash with no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 11, 2020
@gopherbot gopherbot mentioned this issue Aug 11, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.8 milestone Aug 11, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/248477 mentions this issue: [release-branch.go1.14] cmd/internal/obj: fix inline marker issue on s390x

@dmitshur dmitshur modified the milestones: Go1.14.8, Go1.14.9 Sep 1, 2020
@dmitshur dmitshur mentioned this issue Sep 3, 2020
Closed
@dmitshur
Copy link
Contributor

dmitshur commented Sep 3, 2020

Approving per discussion in a release meeting. This backport applies to both 1.15 (#40693) and 1.14 (this issue).

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Sep 3, 2020
@dmitshur dmitshur changed the title plugin: Golang app on linux/s390x sometimes hangs after calling "plugin.Open" [1.14 backport] plugin: program on linux/s390x sometimes hangs after calling "plugin.Open" [1.14 backport] Sep 3, 2020
@dmitshur dmitshur modified the milestones: Go1.14.9, Go1.14.10 Sep 9, 2020
@gopherbot
Copy link
Contributor Author

Closed by merging 77029b7 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Sep 10, 2020
@mundaym @dmitshur
[release-branch.go1.14] cmd/internal/obj: fix inline marker issue on …
77029b7 
…s390x

The optimization that replaces inline markers with pre-existing
instructions assumes that 'Prog' values produced by the compiler are
still reachable after the assembler has run. This was not true on
s390x where the assembler was removing NOP instructions from the
linked list of 'Prog' values. This led to broken inlining data
which in turn caused an infinite loop in the runtime traceback code.

Fix this by stopping the s390x assembler backend removing NOP
values. It does not make any difference to the output of the
assembler because NOP instructions are 0 bytes long anyway.

Note: compiler check omitted from backport to reduce risk of change.

Fixes #40694.

Change-Id: I9f9bdbe895c3478549b5e7e623f9521f841e926a
Reviewed-on: https://go-review.googlesource.com/c/go/+/248477
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
@golang golang locked and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.10
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot