-
Notifications
You must be signed in to change notification settings - Fork 18k
x/tools/gopls: remove workspace packages that no longer exist #40690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 I get this error also. Seems to happen everytime I type something in a go file. Every character. Even if I don't save the file. I have the |
Setting go.useLanguageServer to false will fix the issue for now. |
@leguminosa, @chrisnesbit1, @sioncheng: Please capture your |
welp, today it's not an issue. My computer has gone to sleep since then, but it wasn't a full reboot. perhaps the settings did not go into affect immediately? I can't reproduce the issue atm, but if it starts happening again I will update this ticket with my gopls logs. |
@stamblerre here's my gopls log, I got the error again today, thank you.
|
Thanks for the log! Looks like In the excerpt below, you see the logs that
|
Change https://golang.org/cl/248403 mentions this issue: |
that package ( Perhaps when I check out back to my feature branch (that does not have |
It's definitely possible that We should definitely add a regression test for a workspace package deletion, if we don't already have one. |
I think the log above is already all log from that session, I selected all then pasted it here. But I'll give you the logs again should I encounter the error again on my next session. |
|
ok, I'll look into it, thanks. |
I could've sworn I'd already submitted this CL earlier. We've been sending duplicate package paths to go/packages for no reason. Updates golang/go#40690 Change-Id: I4c0d082a71e53df12991341b015e0ce8f504c318 Reviewed-on: https://go-review.googlesource.com/c/tools/+/248403 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
I am experiencing this issue and have narrowed down when it occurs. It occurs whenever you have a package where the only test files are in package
But if you make any test in that same dir that uses the same package (e.g. EDIT: To repeatedly replicate after a restart/reload, you may have to create that |
Thanks for the repro case, @cretz. I am able to reproduce. I think that https://golang.org/cl/250949 should fix the pop-up, but I'll investigate the underlying causes here. |
Change https://golang.org/cl/251017 mentions this issue: |
This adds tests for golang/go#40690, as well as a case for a bug in changing package names. Updates golang/go#40690 Change-Id: I516404e77728024f8bee3da31a88bad1f1917a9b Reviewed-on: https://go-review.googlesource.com/c/tools/+/251017 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
Change https://golang.org/cl/268157 mentions this issue: |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes (v0.16.1)
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Nothing. The error message pops up frequently out of nowhere, almost randomly without any root cause / action trigger (when I'm changing branch, just moving mouse, or even without doing anything)
What did you expect to see?
Nothing
What did you see instead?
The text was updated successfully, but these errors were encountered: