-
Notifications
You must be signed in to change notification settings - Fork 18k
x/website: unable to use custom path without trailing slash ("/") in an HTML file, if it is named index.html #40665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
Change https://golang.org/cl/251080 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Aug 27, 2020
The redirect to drop index.html must be done using r.URL.Path, not relpath, because those might differ. Cutting len("index.html") bytes off a string that doesn't end in index.html is incorrect. While we're here, silence an annoying log print during go test. For golang/go#40665. Change-Id: I36553b041f53eab9c42da6b77184e90800a97e92 Reviewed-on: https://go-review.googlesource.com/c/tools/+/251080 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Change https://golang.org/cl/251118 mentions this issue: |
MK825
added a commit
to MK825/website
that referenced
this issue
Oct 18, 2022
The other changes in go.mod and go.sum are implied by the updated tools. Fixes golang/go#40665. Change-Id: I874c839d64c7cec21a40278bb47b5f686d766f99 Reviewed-on: https://go-review.googlesource.com/c/website/+/251118 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
var files = []string{ ... }
:What did you expect to see?
The index page I created loads when I visit the directory in a browser.
What did you see instead?
The panic above.
The text was updated successfully, but these errors were encountered: