Skip to content

x/website/internal/dl: include docs on how to init datastore or memcache dependencies #40630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kevinburke1 opened this issue Aug 7, 2020 · 5 comments
Closed

x/website/internal/dl: include docs on how to init datastore or memcache dependencies #40630

kevinburke1 opened this issue Aug 7, 2020 · 5 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@kevinburke1
Copy link

I am trying to make changes to the /dl page, but this page requires the ability to pull data from a memcache or Cloud datastore in order to render the page contents, and it does not look like there is documentation on how to put the necessary data in the Cloud datastore.
@gopherbot gopherbot added this to the Unreleased milestone Aug 7, 2020
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Aug 7, 2020
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 7, 2020
@toothrot
Copy link
Contributor

toothrot commented Aug 7, 2020

/cc @dmitshur

@dmitshur
Copy link
Contributor

dmitshur commented Aug 7, 2020

Unrelated to documentation, please be sure to discuss changes to the /dl page in an issue first.

@kevinburke
Copy link
Contributor

My idea was to try to fall back to loading the release history from internal/history if the datastore is not initialized, but everything seems too tightly coupled to google cloud to make that work.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/254538 mentions this issue: internal/dl: add release dates to dl page

@dmitshur
Copy link
Contributor

dmitshur commented Dec 3, 2021

As of CL 362496 (CC @rsc), a copy of live server data is embedded in the golangorg binary, allowing the go.dev/dl/ page to be rendered and developed locally without needing to set up a datastore or memcache client. With that, I think this issue is resolved.

@dmitshur dmitshur closed this as completed Dec 3, 2021
@golang golang locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@toothrot @kevinburke @dmitshur @gopherbot @kevinburke1