Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: "Search help" button is too conspicuous #40624

Closed
myitcv opened this issue Aug 6, 2020 · 7 comments
Closed

x/pkgsite: "Search help" button is too conspicuous #40624

myitcv opened this issue Aug 6, 2020 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite UX Issues that involve UXD/UXR input
Milestone
pkgsite/frontend

Comments

@myitcv
Copy link
Member

myitcv commented Aug 6, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.59 Safari/537.36

Screenshot

Screen Shot 2020-08-06 at 20 12 05

What did you do?

Visited the page.

What did you expect to see?

A clean layout with items sized according to their importance.

What did you see instead?

My workflow with pkg.go.dev looks like this:

It's a minor point, but I find that my eye is consistently drawn/distracted by the "Search help" button. It's as large/prominent as the "Search" button, even more so perhaps because it (the help button) has an icon.

Could this not be relegated to a "Need help?" link below the examples? The example are already some form of "help", so adding a link beneath them is not that much of a stretch.

Or perhaps a help icon to the right of the search input box itself?

Prior art here is the google.com homepage - where I note there isn't even a help link (which is less useful to my mind)!

Screen Shot 2020-08-06 at 20 17 03
@myitcv myitcv added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Aug 6, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 6, 2020
@julieqiu julieqiu added the UX Issues that involve UXD/UXR input label Aug 13, 2020
@julieqiu
Copy link
Member

Could this not be relegated to a "Need help?" link below the examples? The example are already some form of "help", so adding a link beneath them is not that much of a stretch.

I like this suggestion.

/cc @Joanne881107 @spf13 @fflewddur for product / UX input

@jinhongy
Copy link

The initial plan is to replace this "Search help" with "Advanced search" when that is ready. However, it make sense for now to leverage the this link with the examples below.

@fflewddur
Copy link

I agree, the search help link looks like a button itself, and on systems that order the primary action button to the left (e.g., macOS and most Linux desktops), it's in the exact area you would look to find the primary button. I like Paul's suggested solution, but whichever approach we take, we should ensure that it 1) makes this look less like a button, and 2) moves it out of the primary focus area for macOS and Linux users.

@julieqiu
Copy link
Member

@Joanne881107 would you mind sharing an updated mock for this page?

@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Aug 27, 2020
@gopherbot
Copy link

Change https://golang.org/cl/254878 mentions this issue: content/static: update "Search Help" button on homepage with a11y fixes

@jamalc
Copy link

jamalc commented Sep 16, 2020

Here is a screenshot of the new homepage layout.

gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 16, 2020
@jamalc
content/static: update "Search Help" button on homepage with a11y fixes
ddc09e6 
This change adds various a11y fixes and reconfigures the search help button.

Updates golang/go#40624

Change-Id: Ifaad23aca326a8d88b55d0385eed16d32ddea85c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/254878
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
@julieqiu julieqiu removed the website label Sep 19, 2020
@julieqiu julieqiu removed the website label Sep 19, 2020
@julieqiu
Copy link
Member

Fixed.

@golang golang locked and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite UX Issues that involve UXD/UXR input
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
6 participants
@myitcv @fflewddur @julieqiu @jinhongy @gopherbot @jamalc