Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: add Pipe2 function for Solaris #40613

Closed
andy-js opened this issue Aug 6, 2020 · 5 comments
Closed

x/sys/unix: add Pipe2 function for Solaris #40613

andy-js opened this issue Aug 6, 2020 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris
Milestone
Unreleased

Comments

@andy-js
Copy link
Contributor

andy-js commented Aug 6, 2020

The Pipe2 function is missing from the syscall package on Solaris. Solaris has pipe2 so it could be added.
@andy-js andy-js changed the title syscall.Pipe2 is missing on Solaris src/syscall: Add Pipe2 function for Solaris Aug 6, 2020
@andy-js
Copy link
Contributor Author

andy-js commented Aug 6, 2020

See: #40614

@tklauser
Copy link
Member

tklauser commented Aug 6, 2020

The syscall package is frozen and no new functionality should be added to it (only bug fixes):

go/src/syscall/syscall.go

Lines 21 to 25 in 6f08e89

// Deprecated: this package is locked down. Callers should use the
// corresponding package in the golang.org/x/sys repository instead.
// That is also where updates required by new systems or versions
// should be applied. See https://golang.org/s/go1.4-syscall for more
// information.

However, we may add Pipe2 for Solaris to the golang.org/x/sys/unix package.

@tklauser tklauser changed the title src/syscall: Add Pipe2 function for Solaris x/sys/unix: add Pipe2 function for Solaris Aug 6, 2020
@tklauser tklauser added NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris labels Aug 6, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 6, 2020
@andy-js
Copy link
Contributor Author

andy-js commented Aug 6, 2020

I'll do that. Thanks.

@andy-js andy-js closed this as completed Aug 6, 2020
@tklauser
Copy link
Member

tklauser commented Aug 6, 2020

We can leave this open to track the issue. Issues for x/sys are also in the Go issue tracker, denoted by the x/sysprefix in the subject line. Also see https://github.com/golang/sys#report-issues--send-patches

@tklauser tklauser reopened this Aug 6, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/283032 mentions this issue: unix: add Pipe2 for solaris

@golang golang locked and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@tklauser @andy-js @gopherbot