Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: refactor and improve completion scoring #40599

Closed
stamblerre opened this issue Aug 6, 2020 · 1 comment
Closed

x/tools/gopls: refactor and improve completion scoring #40599

stamblerre opened this issue Aug 6, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Aug 6, 2020 •
edited

The completion ranking logic is scattered and inconsistent. See the following issues that would be fixed by doing a larger refactoring / improvement:

Also, see the discussion on https://golang.org/cl/245130. This makes sense as a stand-alone package that other packages in x/tools can depend on.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 6, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 6, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Aug 6, 2020
@dandua98 dandua98 self-assigned this Sep 12, 2020
@dandua98 dandua98 removed their assignment Oct 2, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
@stamblerre stamblerre changed the title x/tools/gopls: factor ranking logic out of completion into its own package x/tools/gopls: refactor and improve completion scoring Nov 13, 2020
This was referenced Nov 13, 2020
Closed
Closed
Closed
@findleyr
Copy link
Contributor

This is either done, or obsolete.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2022
@golang golang locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
4 participants
@stamblerre @gopherbot @dandua98 @findleyr