Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/blog: Link does not exist given in blog post of playground #40568

Closed
dsaw opened this issue Aug 4, 2020 · 6 comments
Closed

x/blog: Link does not exist given in blog post of playground #40568

dsaw opened this issue Aug 4, 2020 · 6 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dsaw
Copy link

dsaw commented Aug 4, 2020 •
edited by ALTree
Loading

Does this issue reproduce with the latest release?

Issue is coming when reading blog post here - https://blog.golang.org/playground

What did you do?

Click on links given in the following section of post.

The implementation can be found in net_nacl.go. A good place to start reading is netFile, the network socket implementation of the fileImpl interface.

What did you expect to see?

The implementation page on Github .

What did you see instead?

Page not found
@gopherbot gopherbot added this to the Unreleased milestone Aug 4, 2020
@ianlancetaylor
Copy link
Member

I just want to mention that that blog post is describing an older version of the playground, not the one that is currently running.

@ianlancetaylor
Copy link
Member

CC @andybons

@andybons
Copy link
Member

andybons commented Aug 4, 2020

Should be relatively easy to point to a previous commit (instead of master) where this file exists.

@andybons andybons added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Aug 4, 2020
@ianlancetaylor
Copy link
Member

I wonder if we should also add a note to the blog explaining that it does not describe the current version.

@andybons
Copy link
Member

andybons commented Aug 4, 2020

I wonder if we should also add a note to the blog explaining that it does not describe the current version.

We should definitely do this.

@krzysdabro krzysdabro mentioned this issue Oct 1, 2020
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/258697 mentions this issue: content: fix dead links in playground.article

gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
@krzysdabro @andybons
[x/blog] content: fix dead links in playground.article
7e636b8 
Closes golang/go#40568

Change-Id: I95af7cc9f7a937e5593344b10c7257293da889f3
GitHub-Last-Rev: dc378b0a12956d06c9609e2b75ff84a1c5c0c673
GitHub-Pull-Request: golang/blog#45
Reviewed-on: https://go-review.googlesource.com/c/blog/+/258697
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Trust: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
X-Blog-Commit: a83e7e2449f1445d00e61a61cdf4909b84c2b34c
@golang golang locked and limited conversation to collaborators Jan 5, 2022
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
[x/blog] content: fix dead links in playground.article
e4de8ae 
Closes golang/go#40568

Change-Id: I95af7cc9f7a937e5593344b10c7257293da889f3
GitHub-Last-Rev: dc378b0a12956d06c9609e2b75ff84a1c5c0c673
GitHub-Pull-Request: golang/blog#45
Reviewed-on: https://go-review.googlesource.com/c/blog/+/258697
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Trust: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
X-Blog-Commit: a83e7e2449f1445d00e61a61cdf4909b84c2b34c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

content: fix dead links in playground.article krzysdabro/blog
4 participants
@andybons @ianlancetaylor @dsaw @gopherbot