Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: remove autocomplete experiment code #40549

Closed
andybons opened this issue Aug 3, 2020 · 3 comments
Closed

x/pkgsite: remove autocomplete experiment code #40549

andybons opened this issue Aug 3, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/unplanned

Comments

@andybons
Copy link
Member

andybons commented Aug 3, 2020

Given the code churn on the homepage and header, autocomplete no longer works when turned on. As far as I know, no one is actively maintaining it. We should remove the code until we are ready to launch it to users.
@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Aug 3, 2020
@julieqiu julieqiu added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Aug 3, 2020
@dmitshur dmitshur changed the title pkgsite: remove autocomplete experiment code x/pkgsite: remove autocomplete experiment code Aug 3, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 3, 2020
@findleyr
Copy link
Contributor

findleyr commented Aug 3, 2020

I can get this working again, when we're ready to launch.

We can wait until the header code stabilizes, but if that has already happened I'd be happy to fix it rather than remove it.

@andybons
Copy link
Member Author

andybons commented Aug 3, 2020

@findleyr sgtm!

@findleyr findleyr self-assigned this Aug 6, 2020
@findleyr findleyr mentioned this issue Feb 5, 2021
Open
@julieqiu
Copy link
Member

This code has been removed.

@golang golang locked and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@andybons @julieqiu @gopherbot @findleyr