Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: for range loop reading past slice end [1.14 backport] #40501

Closed
gopherbot opened this issue Jul 30, 2020 · 4 comments
Closed

cmd/compile: for range loop reading past slice end [1.14 backport] #40501

gopherbot opened this issue Jul 30, 2020 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.9

Comments

@gopherbot
Copy link

@randall77 requested issue #40367 to be considered for backport to the next 1.14 minor release.

@gopherbot, please open backport issues for 1.14 and 1.13.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 30, 2020
@gopherbot gopherbot mentioned this issue Jul 30, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.7 milestone Jul 30, 2020
@randall77
Copy link
Contributor

This is a rare but serious miscompilation, where loop end conditions aren't respected.

@gopherbot
Copy link
Author

Change https://golang.org/cl/245958 mentions this issue: [release-branch.go1.14] cmd/compile: don't addLocalInductiveFacts if there is no direct edge from if block to phi block

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Jul 30, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jul 30, 2020
@cagedmantis
Copy link
Contributor

This has been approved since it is a serious issue without any known workarounds.

gopherbot pushed a commit that referenced this issue Aug 3, 2020
@randall77 @cagedmantis
[release-branch.go1.14] cmd/compile: don't addLocalInductiveFacts if …
739b9d5 
…there is no direct edge from if block to phi block

Currently in addLocalInductiveFacts, we only check whether
direct edge from if block to phi block exists. If not, the
following logic will treat the phi block as the first successor,
which is wrong.

This patch makes prove pass more conservative, so we disable
some cases in test/prove.go. We will do some optimization in
the following CL and enable these cases then.

Fixes #40501.


Change-Id: I27cf0248f3a82312a6f7dabe11c79a1a34cf5412
Reviewed-on: https://go-review.googlesource.com/c/go/+/244579
Reviewed-by: Zach Jones <zachj1@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/245958
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Author

Closed by merging 739b9d5 to release-branch.go1.14.

@toothrot toothrot modified the milestones: Go1.14.7, Go1.14.8 Aug 6, 2020
@dmitshur dmitshur modified the milestones: Go1.14.8, Go1.14.9 Sep 1, 2020
@golang golang locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.9
Development

No branches or pull requests
5 participants
@toothrot @cagedmantis @dmitshur @randall77 @gopherbot