Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/refactor/eg: test case claims it should be failing, but it isn't. #40497

Open
seebs opened this issue Jul 30, 2020 · 1 comment
Open
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@seebs
Copy link
Contributor

seebs commented Jul 30, 2020

What version of Go are you using (go version)?

1.14

Does this issue reproduce with the latest release?

Sure.

What did you do?

go test

What did you expect to see?

A test failure.

What did you see instead?

The test passed.

This might seem like it's not surprising, but:

	// Should be no match however currently matches due to:
	// https://golang.org/issue/8584
	// Will start failing when this is fixed then just change golden to
	// No match pointer indirect
	// a.Lock()
	a.Lock()

That issue has been fixed for a long time, but apparently it's still matching. I don't yet understand the code's design intent well enough to know whether this comment is wrong, or there's a new/different bug, or ???

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jul 30, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 30, 2020
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 3, 2020
@cagedmantis
Copy link
Contributor

/cc @golang/tools-team

@adonovan adonovan added the Refactoring Issues related to refactoring tools label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants