Skip to content

x/tools/gopls: improve completion for printf args #40485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
muirdm opened this issue Jul 30, 2020 · 1 comment
Closed

x/tools/gopls: improve completion for printf args #40485

muirdm opened this issue Jul 30, 2020 · 1 comment
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@muirdm
Copy link

muirdm commented Jul 30, 2020

It would be cool if gopls could rank completion candidates based on printf verbs:

// prefer ints
fmt.Printf("%d", <>)

We can probably share code with tools/go/analysis/passes/printf/printf.go for most of the hard work.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 30, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 30, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Jul 30, 2020
@stamblerre stamblerre added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Jul 30, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/246699 mentions this issue: internal/lsp/source: improve completion of printf operands

@golang golang locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @muirdm