Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/releasebot: remove obsolete check that the major version is listed on the project page #40476

Closed
dmitshur opened this issue Jul 29, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@dmitshur
Copy link
Contributor

The https://golang.org/project/ page has a "Version history" section that lists major Go releases that have been released. Prior to CL 229483, it needed to be manually updated before each final major release, and so to catch potential mistakes releasebot has a safety check that aborts the release process if the major version isn't listed:

func (w *Work) checkDocs() {
	// Check that the major version is listed on the project page.
	data, err := ioutil.ReadFile(filepath.Join(w.Dir, "gitwork", "doc/contrib.html"))
	if err != nil {
		w.log.Panic(err)
	}
	major := major(w.Version)
	if !strings.Contains(string(data), major) {
		w.logError("doc/contrib.html does not list major version %s", major)
	}
}

(Source: golang.org/x/build/cmd/releasebot/main.go#L595-L605.)

The doc/contrib.html file no longer needs to be manually updated, and it doesn't even exist in the main repo as it was moved to x/website in CL 229485. The check needs to be removed.

/cc @toothrot @cagedmantis @andybons

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jul 29, 2020
@dmitshur dmitshur added this to the Go1.15 milestone Jul 29, 2020
@dmitshur dmitshur self-assigned this Jul 29, 2020
@gopherbot
Copy link

Change https://golang.org/cl/245477 mentions this issue: cmd/releasebot: remove obsolete checkDocs check

@golang golang locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

2 participants