Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: x/tools gerrit change imported from GH constantly shown as just updated #40468

Closed
ALTree opened this issue Jul 29, 2020 · 5 comments
Closed

x/build/cmd/gopherbot: x/tools gerrit change imported from GH constantly shown as just updated #40468

ALTree opened this issue Jul 29, 2020 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@ALTree
Copy link
Member

ALTree commented Jul 29, 2020 •
edited

CL 244799 (imported from a GH PR) is constantly at the top of the page at https://go-review.googlesource.com/q/status:open+-is:wip, like it was just updated; for example now it's 9:12 and it shows "Updated 9:11", but that's not true (the last update was 2 days ago).

Nothing in the change page shows it was changed recently. I suspect gopherbot foul play; maybe some issue in the way it checks for GH updates?

cc @dmitshur
@ALTree ALTree changed the title cmd/build: x/tools gerrit change imported frog GH constantly "just update" cmd/build: x/tools gerrit change imported frog GH constantly shown as just updated Jul 29, 2020
@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 29, 2020
@ALTree ALTree changed the title cmd/build: x/tools gerrit change imported frog GH constantly shown as just updated cmd/gopherbot: x/tools gerrit change imported frog GH constantly shown as just updated Jul 29, 2020
@ALTree
Copy link
Member Author

ALTree commented Aug 6, 2020 •
edited

Happening in https://go-review.googlesource.com/c/tools/+/246737 too. Last modified 2 days ago but the CL is constantly at the top in the main page: https://go-review.googlesource.com/q/status:open+-is:wip and it says it was just updated.

@dmitshur dmitshur changed the title cmd/gopherbot: x/tools gerrit change imported frog GH constantly shown as just updated x/build/cmd/gopherbot: x/tools gerrit change imported frog GH constantly shown as just updated Aug 6, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 6, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 6, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Aug 6, 2020

Issue #40147 may be related to this.

/cc @andybons @toothrot @cagedmantis

@dmitshur dmitshur changed the title x/build/cmd/gopherbot: x/tools gerrit change imported frog GH constantly shown as just updated x/build/cmd/gopherbot: x/tools gerrit change imported from GH constantly shown as just updated Aug 6, 2020
@gopherbot
Copy link

Change https://golang.org/cl/247195 mentions this issue: cmd/gopherbot: temporarily disable assigning reviewers

@andybons
Copy link
Member

andybons commented Aug 6, 2020

Seeing a number of CLs that can no longer be changed due to this:

2020/08/06 19:24:57 No reviewers or cc: https://go-review.googlesource.com/c/net/+/187478
2020/08/06 19:24:57 Setting review on https://go-review.googlesource.com/c/net/+/187478: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:mikioh.public.networking@gmail.com State:}]}
2020/08/06 19:24:57 Could not set review for change "net~187478": HTTP status 409 Conflict; Change 187478 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:24:58 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/223779
2020/08/06 19:24:58 Setting review on https://go-review.googlesource.com/c/tools/+/223779: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:dmitshur@golang.org State:}]}
2020/08/06 19:24:58 Could not set review for change "tools~223779": HTTP status 409 Conflict; Change 223779 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:24:58 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/231464
2020/08/06 19:24:58 Setting review on https://go-review.googlesource.com/c/tools/+/231464: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:dmitshur@golang.org State:}]}
2020/08/06 19:24:58 Could not set review for change "tools~231464": HTTP status 409 Conflict; Change 231464 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:24:58 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/239498
2020/08/06 19:24:58 Setting review on https://go-review.googlesource.com/c/tools/+/239498: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:matloob@golang.org State:}]}
2020/08/06 19:24:58 Could not set review for change "tools~239498": HTTP status 409 Conflict; Change 239498 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:24:58 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/240018
2020/08/06 19:24:58 Setting review on https://go-review.googlesource.com/c/tools/+/240018: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:1080@62eb7196-b449-3ce5-99f1-c037f21e1705 State:}]}
2020/08/06 19:24:58 Could not set review for change "tools~240018": HTTP status 400 Bad Request; )]}'
{
  "reviewers": {
    "1080@62eb7196-b449-3ce5-99f1-c037f21e1705": {
      "input": "1080@62eb7196-b449-3ce5-99f1-c037f21e1705",
      "error": "Account \u00271080@62eb7196-b449-3ce5-99f1-c037f21e1705\u0027 not found\n1080@62eb7196-b449-3ce5-99f1-c037f21e1705 does not identify a registered user or group"
    }
  },
  "error": "error adding reviewer"
}
2020/08/06 19:24:58 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/246737
2020/08/06 19:24:58 Setting review on https://go-review.googlesource.com/c/tools/+/246737: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:matloob@golang.org State:}]}
2020/08/06 19:25:01 No reviewers or cc: https://go-review.googlesource.com/c/text/+/238119
2020/08/06 19:25:01 Setting review on https://go-review.googlesource.com/c/text/+/238119: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:mpvl@golang.org State:}]}
2020/08/06 19:25:01 Could not set review for change "text~238119": HTTP status 409 Conflict; Change 238119 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:25:01 No reviewers or cc: https://go-review.googlesource.com/c/mobile/+/212839
2020/08/06 19:25:01 Setting review on https://go-review.googlesource.com/c/mobile/+/212839: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:hyangah@gmail.com State:}]}
2020/08/06 19:25:01 Could not set review for change "mobile~212839": HTTP status 409 Conflict; Change 212839 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:25:01 No reviewers or cc: https://go-review.googlesource.com/c/mobile/+/231681
2020/08/06 19:25:01 Setting review on https://go-review.googlesource.com/c/mobile/+/231681: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:hyangah@gmail.com State:}]}
2020/08/06 19:25:01 Could not set review for change "mobile~231681": HTTP status 409 Conflict; Change 231681 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:25:01 No reviewers or cc: https://go-review.googlesource.com/c/mobile/+/234239
2020/08/06 19:25:01 Setting review on https://go-review.googlesource.com/c/mobile/+/234239: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:hyangah@gmail.com State:}]}
2020/08/06 19:25:02 Could not set review for change "mobile~234239": HTTP status 409 Conflict; Change 234239 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:25:02 No reviewers or cc: https://go-review.googlesource.com/c/mobile/+/240009
2020/08/06 19:25:02 Setting review on https://go-review.googlesource.com/c/mobile/+/240009: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:hyangah@gmail.com State:}]}
2020/08/06 19:25:02 Could not set review for change "mobile~240009": HTTP status 409 Conflict; Change 240009 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:25:02 No reviewers or cc: https://go-review.googlesource.com/c/go/+/223118
2020/08/06 19:25:02 Setting review on https://go-review.googlesource.com/c/go/+/223118: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:bradfitz@golang.org State:}]}
2020/08/06 19:25:02 Could not set review for change "go~223118": HTTP status 409 Conflict; Change 223118 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.

@stamblerre

gopherbot pushed a commit to golang/build that referenced this issue Aug 6, 2020
@andybons
cmd/gopherbot: temporarily disable assigning reviewers
c32acf8 
This is potentially caught in an infinite loop, which updates
a Gerrit change too many times, leaving the change in an unusable
state.

Also adds a map of deleted issues to prevent an error loop caused
by attempting to post changes to issues that don’t exist.

Updates golang/go#40147
Updates golang/go#40468

Change-Id: I3922d63c146591809324861d40437f43e115748c
Reviewed-on: https://go-review.googlesource.com/c/build/+/247195
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/247239 mentions this issue: cmd/gopherbot: fix bug causing infinite reviewer assignments

@golang golang locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@andybons @dmitshur @ALTree @gopherbot