Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: renaming a symbol from its use does not fix its comment #40463

Closed
stamblerre opened this issue Jul 28, 2020 · 1 comment
Closed

x/tools/gopls: renaming a symbol from its use does not fix its comment #40463

stamblerre opened this issue Jul 28, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.0

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Jul 28, 2020 •
edited

Renaming a variable or function from its declaration fixes its comment. Renaming from a use doesn't.
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jul 28, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 28, 2020
@gopherbot
Copy link

Change https://golang.org/cl/245817 mentions this issue: internal/lsp: get the correct declaration node when finding references

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v.0.4.5 Aug 4, 2020
@golang golang locked and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.0
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot