Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add a regression test for the upgrade code lens when -mod=readonly is set #40455

Closed
stamblerre opened this issue Jul 28, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@stamblerre
Copy link
Contributor

Add a regression test for https://go-review.googlesource.com/c/tools/+/232477.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jul 28, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 28, 2020
@stamblerre stamblerre added the Testing An issue that has been verified to require only test changes, not just a test failure. label Sep 9, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Critical to Testing in vscode-go: gopls by default Nov 10, 2020
@stamblerre
Copy link
Contributor Author

This is no longer relevant, as default to -mod=readonly and the upgrade code lenses have been changed.

vscode-go: gopls by default automation moved this from Testing to Done Dec 15, 2020
@stamblerre stamblerre removed this from the gopls/vscode-go milestone Dec 15, 2020
@golang golang locked and limited conversation to collaborators Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
Development

No branches or pull requests

2 participants