Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compress/lzw: improve encoder performance with better hash function #40425

Open
heisen-li opened this issue Jul 27, 2020 · 3 comments
Open

compress/lzw: improve encoder performance with better hash function #40425

heisen-li opened this issue Jul 27, 2020 · 3 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Unplanned

Comments

@heisen-li
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.14.2 windows/amd64

Does this issue reproduce with the latest release?

yes

What did you do?

I found a CL from a long time ago, https://go-review.googlesource.com/c/go/+/123478, and the changes in it have greatly improved performance. But some of the work authors have not yet completed and disappeared. I want to resubmit the CL and complete the work for him, can I? Do you accept merge in this way?

@dsnet @mdempsky
@ALTree ALTree changed the title compress/LZW: Resubmit the CL and complete the unfinished work in the CL compress/lzw: resubmit the CL and complete the unfinished work in the CL Jul 27, 2020
@ALTree ALTree added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jul 27, 2020
@ALTree ALTree added this to the Unplanned milestone Jul 27, 2020
@mdempsky
Copy link
Member

Seems like the only outstanding issue on that CL was to test some other hash functions and see if they do any better. Do you want to try benchmarking that code (to reproduce the author's results) as well as the alternative hash function @dsnet suggested to see how it compares?

Once we have that, I think we can either just submit that CL, or submit an alternative one with a better hash function.

@mdempsky mdempsky changed the title compress/lzw: resubmit the CL and complete the unfinished work in the CL compress/lzw: improve encoder performance with better hash function Jul 27, 2020
@heisen-li
Copy link
Contributor Author

submit an alternative one with a better hash function.

In addition to this work, @nigeltao said in the comments below that the file size after encoding needs to be evaluated. I think this is what he did not do. I can spend some time to complete these tasks. include:

  1. Compare the encoding size before and after modification, which is the change of compression rate.
  2. Compare some other hash algorithms. See if there is a better way.@dsnet

If possible, I would like to open a new CL and add detailed information to it, or reply to the information I got in the previous CL.

@gopherbot
Copy link

Change https://golang.org/cl/245177 mentions this issue: compress/lzw: optimize code hash table to reduce collisions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@mdempsky @ALTree @gopherbot @heisen-li