Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: notes don't render in documentation #40346

Closed
jba opened this issue Jul 22, 2020 · 1 comment
Closed

x/pkgsite: notes don't render in documentation #40346

jba opened this issue Jul 22, 2020 · 1 comment
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
Unreleased

Comments

@jba
Copy link
Contributor

jba commented Jul 22, 2020

The HTML IDs for notes need to be safehtml.Identifiers, and they are just strings. That causes an error during safehtml template execution.
@jba jba added the pkgsite label Jul 22, 2020
@jba jba self-assigned this Jul 22, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 22, 2020
@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 22, 2020
@gopherbot
Copy link

Change https://golang.org/cl/244257 mentions this issue: internal/fetch/dochtml: use safe identifiers for notes

@golang golang locked and limited conversation to collaborators Jul 23, 2021
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@julieqiu @gopherbot @jba