Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support gomvpkg as a command #40341

Open
stamblerre opened this issue Jul 22, 2020 · 2 comments
Open

x/tools/gopls: support gomvpkg as a command #40341

stamblerre opened this issue Jul 22, 2020 · 2 comments
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Thinking Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@stamblerre
Copy link
Contributor

See https://pkg.go.dev/golang.org/x/tools/cmd/gomvpkg?tab=doc.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 22, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 22, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Jul 22, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
@gopherbot
Copy link

Change https://go.dev/cl/425955 mentions this issue: gopls: Add support for gomvpkg as a command.

@findleyr
Copy link
Contributor

I think once #41567 is complete, there will be less need for implementing package renaming as a command, though gomvpkg still supports features that simple package renaming will not (at least in its initial revision).

We should reconsider how this interacts with package renaming via the textDocument/rename request: what are the critical features provided by gomvpkg, and how can we best expose them through the LSP.

For example, one feature that the current package renaming implementation will not support is moving a package to an arbitrary other location: we can move foo/a to foo/b by renaming a->b in the package declaration package a, but we can't move foo/a to internal/a. Should we support this via a custom command (as is suggested by this issue), or by "hacks" on top of textDocument/rename, for example renaming a->../internal/a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Thinking Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants