Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add checks to all.bash for JS compile errors #40333

Closed
julieqiu opened this issue Jul 21, 2020 · 1 comment
Closed

x/pkgsite: add checks to all.bash for JS compile errors #40333

julieqiu opened this issue Jul 21, 2020 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@julieqiu
Copy link
Member

At the moment, the all.bash does not check for any common JS issues, such as an undefined variable or type errors. We should add steps to help catch these issues to the all.bash.

/cc @andybons @jba @jamalc
@julieqiu julieqiu added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Jul 21, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 21, 2020
@julieqiu julieqiu removed the website label Sep 19, 2020
@julieqiu julieqiu removed the website label Sep 19, 2020
@jamalc jamalc self-assigned this Feb 26, 2021
@jamalc
Copy link

jamalc commented Feb 26, 2021

We now have these checks as part of the work from #40960.

@jamalc jamalc closed this as completed Feb 26, 2021
@golang golang locked and limited conversation to collaborators Feb 26, 2022
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
4 participants
@hyangah @julieqiu @gopherbot @jamalc