Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: move circular dependency tests to regression tests #40332

Closed
stamblerre opened this issue Jul 21, 2020 · 1 comment
Closed

x/tools/gopls: move circular dependency tests to regression tests #40332

stamblerre opened this issue Jul 21, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@stamblerre
Copy link
Contributor

These have always been finicky, and there are some special cases just for those tests. I think they would work better as regression tests.

@stamblerre stamblerre added this to the gopls/v0.4.4 milestone Jul 21, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 21, 2020
@stamblerre stamblerre added the Testing An issue that has been verified to require only test changes, not just a test failure. label Sep 17, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Non-critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Non-critical to Testing in vscode-go: gopls by default Nov 10, 2020
@gopherbot
Copy link

Change https://golang.org/cl/272207 mentions this issue: gopls/internal/regtest: convert circular import tests to regtests

vscode-go: gopls by default automation moved this from Testing to Done Nov 23, 2020
@golang golang locked and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
Development

No branches or pull requests

2 participants