Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: bad diagnostic for new file #40265

Closed
stamblerre opened this issue Jul 17, 2020 · 1 comment
Closed

x/tools/gopls: bad diagnostic for new file #40265

stamblerre opened this issue Jul 17, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@stamblerre
Copy link
Contributor

Repro steps:

  1. Create new folder and new file in VS Code (in my case, I created internal/lsp/modfile and internal/lsp/modfile/modfile.go in internal/lsp).
  2. Add package declaration (package modfile)
  3. Insert comment above (in my case, added the Go copyright)

Observe bad diagnostics (expected declaration, got 'o')

@stamblerre stamblerre added this to the gopls/v0.4.4 milestone Jul 17, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 17, 2020
@stamblerre
Copy link
Contributor Author

I'm no longer able to reproduce this. Will reopen if I find a way to.

@golang golang locked and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants