New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/exp/cmd/gorelease: module source tree too large #40263
Comments
Is this a regression? What are the contents and the size of the directory where you ran /cc @jayconrod |
https://github.com/golang/mod/blob/89ce4c7ba8043b0e8a8c03f1a266fb0e56637314/zip/zip.go#L28-L30 |
The reproducer is an internal repo, so I am not sure I can share it. That being said, it does not reproduce on other modules or with an older version of gorelease, CL 197299/4. |
Is the source tree actually that large? Or can this be reproduced with a smaller tree? If so, how? The |
Considering that |
In the diff between patch set 4 of CL 197299 and the final patch set 15 that was merged, the go.mod went from requiring golang.org/x/mod at v0.1.0 to v0.1.1-0.20191107180719-034126e5016b. That change implemented the check that "total size in bytes of a module zip file may be at most MaxZipFile bytes (500 MiB)" that @hyangah pointed out above. |
Awesome thanks for the bisect!. Is this supposed to break for |
When downloading a module
For debugging, can you confirm the size of files within the module? I can't give a good one-liner to do that: |
Found the issue, the module is for a library that is polyglottal and |
A more descriptive error would be good. Or a pointer to a more complete description (#37414). I realize from this discussion that it's not at all obvious why |
If a very large file or directory is not committed, it would not be a real problem, so Edit: On the other hand, it may be a real problem if the code requires that file to be present in the module, so things work during local testing, but not after the module is published. But I don't know for sure if detecting that type of issue is in scope for |
I concur, in general I think the error is warranted, just a little confusing. I was including non Go artefacts in a module, so that issue is mine. Relatedly, I moved all NodeJS code in the repo to |
Yes, that would probably be the easiest thing. |
That is more than a little ungainly, but |
Module zip files describes this restriction and others. I can't claim it's authoritative yet (still in draft state), but it will be in the future when it's complete. |
sgtm, I think using #37414 to track the new glossary code is fine, so I will close this out. |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
What did you see instead?
The text was updated successfully, but these errors were encountered: