Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: allow CORS for golang.org/dl/?mode=json requests #40253

Closed
andybons opened this issue Jul 16, 2020 · 1 comment
Closed

x/website: allow CORS for golang.org/dl/?mode=json requests #40253

andybons opened this issue Jul 16, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@andybons
Copy link
Member

Users should be able to fetch the JSON representation of releases via Cross-Origin Resource Sharing. This issue tracks that effort.
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 16, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 16, 2020
@andybons andybons self-assigned this Jul 16, 2020
@gopherbot
Copy link

Change https://golang.org/cl/243118 mentions this issue: internal/dl: add CORS support to JSON endpoint

@golang golang locked and limited conversation to collaborators Jul 16, 2021
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
internal/dl: add CORS support to JSON endpoint
4d05872 
This change allows users to request golang.org/dl/?mode=json
via Cross-Origin Resource Sharing (CORS).

It also removes the golangorg build tag as it did not seem
necessary and adds tests for the “include” GET parameter.

Updates golang/go#29206
Fixes golang/go#40253

Change-Id: I5306a264c4ac2a6e6f49cfb53db01eef6b7f4473
Reviewed-on: https://go-review.googlesource.com/c/website/+/243118
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@andybons @gopherbot