Skip to content

x/pkgsite: consolidate keyboard shortcut behavior across site #40246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andybons opened this issue Jul 16, 2020 · 6 comments
Closed

x/pkgsite: consolidate keyboard shortcut behavior across site #40246

andybons opened this issue Jul 16, 2020 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@andybons
Copy link
Member

There are few places where we handle keyboard shortcuts on the site, and these should be consolidated into a sensible design to more easily avoid conflicts and code duplication.
@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Jul 16, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 16, 2020
@AceroM
Copy link

AceroM commented Jul 16, 2020 •
edited
Loading

In most popular websites (reddit, github etc...) typing "?" would bring up a dialog to list available keyboard shortcuts, would this be something we can consider?

@andybons
Copy link
Member Author

@AceroM That exists right now at least on the Doc tab. It seems to make sense to have it on other pages, but that’s not really what this issue is about.

@andybons andybons assigned andybons and unassigned andybons Jul 16, 2020
@andybons
Copy link
Member Author

Apologies @AceroM as I didn’t exactly clarify what this issue was about 😄 .

This issue is about coming up with a solid architecture design on the frontend for handling keyboard shortcuts in code. It’s not focused on visual design or UI elements on the page.

@julieqiu julieqiu removed the website label Sep 19, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/276233 mentions this issue: content/static: move all keyboard scripts to keyboard.js

@jamalc jamalc closed this as completed Aug 30, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/346429 mentions this issue: static: use keyboard controller for modal shortcuts

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/346437 mentions this issue: static: use keyboard controller for modal shortcuts

gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 1, 2021
@jamalc
static: use keyboard controller for modal shortcuts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
74e8e09 
For golang/go#40246

Change-Id: Icd7b31b1b23e4f19495f2feee8672426e57db597
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/346437
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@golang golang locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
6 participants
@andybons @hyangah @julieqiu @gopherbot @jamalc @AceroM