Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: show search box on smaller viewports #40220

Closed
mleonhard opened this issue Jul 14, 2020 · 3 comments
Closed

x/website: show search box on smaller viewports #40220

mleonhard opened this issue Jul 14, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@mleonhard
Copy link

What did you do?

  1. Go to https://golang.org/
  2. Look around for a search button.
  3. Click the three-bars icon to display the menu.
  4. See the Search box.

What did you expect to see?

The search box appearing at the top or side of the page, like other official language documentation sites:

What did you see instead?

Golang's search box is hidden behind a menu. Out of all the language documentation websites I found, Golang's is the only one that hides the search box.
@gopherbot gopherbot added this to the Unreleased milestone Jul 14, 2020
@andybons andybons changed the title x/website: Make search box visible at all times x/website: show search box on smaller viewports Jul 15, 2020
@andybons
Copy link
Member

As a note, the search box is only hidden behind a menu when the viewport width is below a certain threshold. It should not always be hidden.

image

Renaming this issue to be about making the search box visible on all viewport sizes.

@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 15, 2020
@magical
Copy link
Contributor

magical commented Feb 20, 2021

It looks like the search box may be removed entirely (#44357), in which case this issue can be closed.

@dmitshur
Copy link
Contributor

Indeed, this isn't relevant by now, closing.

@mleonhard mleonhard mentioned this issue Jun 25, 2021
Closed
@golang golang locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@magical @andybons @mleonhard @dmitshur @gopherbot